custom data readers loader should not recurse further than first subdirectories of sys.path #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of syspath entries.
chrisrink10
reviewed
Nov 22, 2024
chrisrink10
approved these changes
Nov 22, 2024
|
Thanks @chrisrink10 for the review and suggestions! Basilisp feels noticeably quicker to bootstrap within its own project (though perhaps I'm just biased by the fix 😅). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please review patch to only have the custom data reader loader only considers up to the first level subdirectories in the
sys.pathentries. It addresses #1135.I've used transducers to improve performance, which required moving the custom data loaders code further down the namespace. The only function that changes is
data-readers-files, which now only processes the top directory and immediate subdirectories.I've adjusted the a test not to expect any readers to be found further down the subdirectories, andfixed a test which should have referred to
test/test5`.I've also updated the documentation to indicate the change in behavior.
Thanks
cc @mitch-kyle